add JsonConstructorAttribute to internal Method() constructor
#1586
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bertk
added
bug
MarcoRossignoli
approved these changes
Jan 16, 2024
|
@Bertk are you positive that this solves the problem? I tried it yesterday real quick with a self-compiled version and still faced this issue. Could be that I did something wrong but didn't have more time to investigate. |
|
I hadn't had a chance to validate using the package from the CI pipeline and was going to try and do so momentarily. Will let you know if it fixes my issue |
|
@daveMueller see my comment on #1583 . It does not fix it for me either and I don't think it will for anyone. |
|
@daveMueller No I was not convinced to solve the issue and ask for feedback.
@pinkfloydx33 Thank you for the analysis. I was not aware of this limitation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1583